jojochuang commented on code in PR #8741:
URL: https://github.com/apache/hadoop/pull/8741#discussion_r4041572048
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##########
@@ -3387,6 +3388,8 @@ boolean renameTo(String src, String dst, boolean
logRetryCache)
} catch (AccessControlException e) {
logAuditEvent(false, operationName, src, dst, null);
throw e;
+ } finally {
+ FSPermissionChecker.setRenameToTrash(false);
Review Comment:
this one's redundant.
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java:
##########
@@ -163,6 +165,14 @@ public static void setOperationType(String opType) {
operationType.set(opType);
}
+ public static void setRenameToTrash(boolean value) {
Review Comment:
please add javadoc to explain what this flag mean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
