[
https://issues.apache.org/jira/browse/HADOOP-19991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18117075#comment-18117075
]
ASF GitHub Bot commented on HADOOP-19991:
-----------------------------------------
deepujain commented on PR #8305:
URL: https://github.com/apache/hadoop/pull/8305#issuecomment-5742793480
Rebased onto trunk `a3febb258` and pushed `2d180683`. Updated the regression
references to HADOOP-19991 and fixed the Yetus field-visibility warning by
making the recorded configuration private.
`TestSignerManager` passed all 10 tests in Docker with Maven 3.9.15 / JDK
17, zero failures, errors, or skips. The PR description now records the exact
command and limits. No object-store integration endpoint was exercised. A
standalone Checkstyle attempt could not resolve reactor snapshot dependencies;
fresh CI still needs to verify it.
The previous Build check reported workflow-run detection failure, not a test
failure. Fork Actions are enabled; checking the new run after this rebase.
> S3A: Pass configuration to Configurable HTTP signers
> ----------------------------------------------------
>
> Key: HADOOP-19991
> URL: https://issues.apache.org/jira/browse/HADOOP-19991
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/s3
> Reporter: Deepak Jain (DJ)
> Assignee: Deepak Jain (DJ)
> Priority: Major
> Labels: pull-request-available
>
> {{SignerFactory.createHttpSigner creates custom HTTP signers without passing
> the caller's Hadoop Configuration to implementations of Configurable. }}
> {{}}
> {{These signers therefore cannot read the supplied configuration.
> HADOOP-19805 added configuration propagation for the other signer creation
> path. This issue tracks the remaining HTTP signer path.}}
> {{Expected behavior:
> After constructing an HTTP signer that implements Configurable, call setConf
> with the supplied Configuration before wrapping it in the authentication
> scheme. }}
> {{}}
> {{Signers that do not implement Configurable should continue working
> unchanged.
> Existing patch:
> https://github.com/apache/hadoop/pull/8305}}
> {{The patch includes
> TestSignerManager.testCreateHttpSignerSetsConfWhenConfigurable, which
> verifies that the signer receives the same Configuration instance supplied to
> the factory.}}
> {{}}
> {{Related issue:
> https://issues.apache.org/jira/browse/HADOOP-19805}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
