[
https://issues.apache.org/jira/browse/HADOOP-19988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18118755#comment-18118755
]
ASF GitHub Bot commented on HADOOP-19988:
-----------------------------------------
slfan1989 commented on code in PR #8727:
URL: https://github.com/apache/hadoop/pull/8727#discussion_r4092263800
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestProxyUriUtils.java:
##########
@@ -85,6 +85,18 @@ void testGetProxyUri() throws Exception {
}
+ @Test
+ void testGetProxyUriWithWebAppPath() throws Exception {
Review Comment:
Thanks for the fix. Could we add a regression test in `TestAMWebApp` that
exercises the actual redirect and route changes?
The new test only checks `ProxyUriUtils.getProxyUri()`, which is unchanged
and already supports URLs containing paths. It would still pass if both changes
to `AMWebApp` were reverted, so it does not protect against the reported 404
regression.
Please start the AM WebApp and verify that:
- Requesting `/` redirects to `/mapreduce/app`.
- Following the redirect returns HTTP 200 with the expected application page
content.
Please also ensure the test cleans up both the client service and the MRApp
in a `finally` block.
> Fix AM tracking URL: redirect root to /mapreduce/app
> ----------------------------------------------------
>
> Key: HADOOP-19988
> URL: https://issues.apache.org/jira/browse/HADOOP-19988
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Riya Khandelwal
> Assignee: Riya Khandelwal
> Priority: Minor
> Labels: pull-request-available
>
> On the YARN UI clicking on the application tracking URL results in 404:
> !https://media-cdn.atlassian.com/file/ee685c9b-d147-44aa-a65d-e320df8dcc57/image/cdn?allowAnimated=true&client=b47d7f8e-a692-4580-bc50-5af50f9cf45a&collection=&height=125&max-age=2592000&mode=full-fit&source=mediaCard&token=eyJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJiNDdkN2Y4ZS1hNjkyLTQ1ODAtYmM1MC01YWY1MGY5Y2Y0NWEiLCJhY2Nlc3MiOnsidXJuOmZpbGVzdG9yZTpmaWxlOmVlNjg1YzliLWQxNDctNDRhYS1hNjVkLWUzMjBkZjhkY2M1NyI6WyJyZWFkIl19LCJleHAiOjE3ODg4NDU2NjksIm5iZiI6MTc4ODg0NDc2OSwiYWFJZCI6IjYzMDE2NWQ5NmQyNjYzMjg4OWRmYWI2YyIsImh0dHBzOi8vaWQuYXRsYXNzaWFuLmNvbS9hcHBBY2NyZWRpdGVkIjpmYWxzZX0.MUWqCJk8G1GDK9aVS873W193r7B90jyxMIpdltCljkA&width=671#media-blob-url=true&id=ee685c9b-d147-44aa-a65d-e320df8dcc57&clientId=b47d7f8e-a692-4580-bc50-5af50f9cf45a&contextId=&collection=|width=465,height=185!
> Appending /mapreduce/app at the end of URL will render to the correct page.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
