slfan1989 commented on code in PR #8727:
URL: https://github.com/apache/hadoop/pull/8727#discussion_r4092263800
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestProxyUriUtils.java:
##########
@@ -85,6 +85,18 @@ void testGetProxyUri() throws Exception {
}
+ @Test
+ void testGetProxyUriWithWebAppPath() throws Exception {
Review Comment:
Thanks for the fix. Could we add a regression test in `TestAMWebApp` that
exercises the actual redirect and route changes?
The new test only checks `ProxyUriUtils.getProxyUri()`, which is unchanged
and already supports URLs containing paths. It would still pass if both changes
to `AMWebApp` were reverted, so it does not protect against the reported 404
regression.
Please start the AM WebApp and verify that:
- Requesting `/` redirects to `/mapreduce/app`.
- Following the redirect returns HTTP 200 with the expected application page
content.
Please also ensure the test cleans up both the client service and the MRApp
in a `finally` block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
