[
https://issues.apache.org/jira/browse/HADOOP-19993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Chiu Chuang updated HADOOP-19993:
-------------------------------------
Component/s: common
Description:
After YARN-11977 added the MCP HTTP server in hadoop-common, SpotBugs reports
one remaining warning on trunk in hadoop-common-project/hadoop-common:
* SE_BAD_FIELD: Class org.apache.hadoop.mcp.McpHttpServlet defines
non-transient non-serializable instance field requestHandler
Yetus runs with spotbugs-strict-precheck. While this warning exists on trunk,
PRs that build modules depending on hadoop-common can fail precommit with:
{code}hadoop-common-project/hadoop-common in trunk has 1 extant spotbugs
warnings.{code}
even when patch SpotBugs and unit tests pass (example: PR-8744 / HDFS-17981).
*Fix:* mark servlet dependency fields transient (HttpServlet is Serializable
but instances are not serialized in normal use).
*Pull request:* https://github.com/apache/hadoop/pull/8753
was:SpotBugs SE_BAD_FIELD on
org.apache.hadoop.mcp.McpHttpServlet.requestHandler breaks Yetus
spotbugs-strict-precheck on trunk hadoop-common. Follow-up to YARN-11977. Fix
in PR https://github.com/apache/hadoop/pull/8753
> Fix SpotBugs SE_BAD_FIELD in McpHttpServlet blocking trunk precommit
> --------------------------------------------------------------------
>
> Key: HADOOP-19993
> URL: https://issues.apache.org/jira/browse/HADOOP-19993
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
> Reporter: Wei-Chiu Chuang
> Priority: Major
>
> After YARN-11977 added the MCP HTTP server in hadoop-common, SpotBugs reports
> one remaining warning on trunk in hadoop-common-project/hadoop-common:
> * SE_BAD_FIELD: Class org.apache.hadoop.mcp.McpHttpServlet defines
> non-transient non-serializable instance field requestHandler
> Yetus runs with spotbugs-strict-precheck. While this warning exists on trunk,
> PRs that build modules depending on hadoop-common can fail precommit with:
> {code}hadoop-common-project/hadoop-common in trunk has 1 extant spotbugs
> warnings.{code}
> even when patch SpotBugs and unit tests pass (example: PR-8744 / HDFS-17981).
> *Fix:* mark servlet dependency fields transient (HttpServlet is Serializable
> but instances are not serialized in normal use).
> *Pull request:* https://github.com/apache/hadoop/pull/8753
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
