Hean-Chhinling commented on PR #8641: URL: https://github.com/apache/hadoop/pull/8641#issuecomment-5827032828
> Thanks for adding validation on both the UI and backend sides. > > I left two inline comments: > > * The UI validation should honor inherited label access, consistent with the backend. > * Please remove the unused import from Vitest's internal declaration chunk. > > I also share the compatibility concern raised by @brumi1024: rejecting implicit label inheritance from root would invalidate previously supported configurations and could prevent ResourceManager startup. This should be resolved before merging. > > Review was based on code inspection; I have not run the tests locally. Thank you so much for rechecking back on this PR, @slfan1989! Regarding the implicit label inheritance from root is still a question for me. If I follow that behaviour the bug, would still be present. E.g. The root.default.leaf does not have accessible-node-labels to label3 then if it goes always up to root it will behave as if the root.default.leaf is accessible to label3. That is not an ideal way and would cause this bug. If you have any ideas how we could proceed with this, please let me know. My first idea now is to enforce this check only in the UI so the backend would not break existing RM start up. But this is not really an ideal way :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
