[
https://issues.apache.org/jira/browse/HADOOP-18881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18119165#comment-18119165
]
ASF GitHub Bot commented on HADOOP-18881:
-----------------------------------------
zeekling opened a new pull request, #8756:
URL: https://github.com/apache/hadoop/pull/8756
… issue
Root cause: ZKDelegationTokenSecretManager#incrSharedCount uses
SharedCount.trySetCount which fails when ZNode dataVersion overflows int
(2147483647). Curator 5.7.0 fixes this via CURATOR-688.
Changes:
- hadoop-project/pom.xml: curator.version 5.2.0 -> 5.7.0
- LICENSE-binary: curator-client/framework/recipes 5.2.0 -> 5.7.0
Impact:
- 13 modules affected
- No breaking API changes (Curator 5.x main version compatible)
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
### How was this patch tested?
### For code changes:
- [ ] Does the title of this PR start with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: Have the integration tests been executed and the
endpoint
declared according to the connector-specific documentation? *Note:
Automated CI
testing doesn't cover all cases so manual testing with cloud storage
is still
required.*
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
### AI Tooling
If an AI tool was used:
- [ ] The PR includes the phrase "Contains content generated by <tool>"
where <tool> is the name of the AI tool used.
- [ ] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
> ZKDTSM could be stuck when meet znode version overflow
> ------------------------------------------------------
>
> Key: HADOOP-18881
> URL: https://issues.apache.org/jira/browse/HADOOP-18881
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Xiaoqiao He
> Assignee: Xiaoqiao He
> Priority: Critical
>
> ZKDTSM could be stuck when meet znode (/zkdtsm/ZKDTSMRoot/ZKDTSMSeqNumRoot)
> version int overflow (2147483647). It can not recovery even restart
> Application which may include YARN Router, DFS Router, KMS and other modules
> who use zookeeper to manage Token. One solution (not very smooth) is delete
> this znode first and then restart Service.
> The root cause is following code snippet and curator could not compatible
> with version overflow. I try to give a draft improvement at CURATOR-688.
> Welcome to any discussion if we could resolve it at Hadoop side smooth.
> org.apache.hadoop.security.token.delegation.ZKDelegationTokenSecretManager#incrSharedCount
> {code:java}
> private int incrSharedCount(SharedCount sharedCount, int batchSize)
> throws Exception {
> while (true) {
> // Loop until we successfully increment the counter
> VersionedValue<Integer> versionedValue =
> sharedCount.getVersionedValue();
> if (sharedCount.trySetCount(
> versionedValue, versionedValue.getValue() + batchSize)) {
> return versionedValue.getValue();
> }
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
