joseluisll opened a new pull request, #8772: URL: https://github.com/apache/hadoop/pull/8772
### Description of PR JIRA: https://issues.apache.org/jira/browse/HADOOP-19995 HADOOP-19731 added `dev-support/findbugs-exclude-global.xml` and connected it to the `spotbugs-maven-plugin` configuration of about 30 modules, but `hadoop-resourceestimator` was left out. It is the only `hadoop-tools` module with no spotbugs plugin configuration of its own. It therefore uses the root plugin with no exclude filters, so `CT_CONSTRUCTOR_THROW` and `EI_EXPOSE_REP` / `EI_EXPOSE_REP2` findings count as errors. Any precommit run that touches this module fails because of them (for example apache/hadoop#8704 / HADOOP-19972). This PR adds the `spotbugs-maven-plugin` configuration to `hadoop-tools/hadoop-resourceestimator/pom.xml`. It points at the shared global exclude file in the same way as the sibling modules (`xmlOutput=true`, `excludeFilterFile=${maven.multiModuleProjectDirectory}/dev-support/findbugs-exclude-global.xml`). Only the build configuration changes. There are no Java source changes. ### How was this patch tested? Ran locally: mvn -pl hadoop-tools/hadoop-resourceestimator compile spotbugs:check - Before the change: 12 bugs reported, BUILD FAILURE - After the change: 0 findings, BUILD SUCCESS Module unit tests: 47 run, 0 failures, 0 errors. ### For code changes: - [x] Does the title of this PR start with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: Have the integration tests been executed and the endpoint declared according to the connector-specific documentation? — N/A, no object store connector touched. - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? — N/A, no new dependencies. - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? — N/A. ### AI Tooling If an AI tool was used: - [x] The PR includes the phrase "Contains content generated by Claude Code" where <tool> is the name of the AI tool used. - [x] My use of AI contributions follows the ASF legal policy https://www.apache.org/legal/generative-tooling.html Contains content generated by Claude Code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
