craffit opened a new pull request, #8778: URL: https://github.com/apache/hadoop/pull/8778
### Description of PR JIRA: https://issues.apache.org/jira/browse/HDFS-17984 While a DataNode is starting, `initReplicaRecovery` can be served after the FsDataset exists but before the block pool's replicas are loaded into the replica map. It then answers "no replica" (null), which `BlockRecoveryWorker` does not count as an error; if the other replicas fail, the sync list is empty and the block is deleted although the restarting DataNode holds a valid replica. `FsDatasetImpl` now records per block pool when its replicas have been loaded (`addBlockPool`, cleared in `shutdownBlockPool`), and `initReplicaRecovery` throws while they are not, so the DataNode counts as failed and block recovery is retried. A no-op `DataNodeFaultInjector#delayLoadingReplicas` hook is added before the replicas are loaded. `TestInterDatanodeProtocol` used a non-existent block pool to get a "missing block" null response. A DataNode cannot tell such a pool from one it has not loaded yet, so the test now checks a missing block in the loaded pool for null, and that an unknown pool is rejected. ### How was this patch tested? Added `TestBlockRecovery2#testBlockRecoveryWhileReplicasAreLoading`: one replica is unusable and the other DataNode is held while loading its replicas after a restart; it checks that the file is recovered with the restarting DataNode's replica instead of being closed without the block. ### For code changes: - [x] Does the title of this PR start with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: Have the integration tests been executed and the endpoint declared according to the connector-specific documentation? (N/A) - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? (N/A) - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? (N/A) ### AI Tooling If an AI tool was used: - [x] The PR includes the phrase "Contains content generated by <tool>" where <tool> is the name of the AI tool used. - [x] My use of AI contributions follows the ASF legal policy https://www.apache.org/legal/generative-tooling.html Contains content generated by Claude Code. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
