slfan1989 commented on PR #8770: URL: https://github.com/apache/hadoop/pull/8770#issuecomment-5967778638
> **CI update for [Jenkins run #1](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8770/1/):** The fork Build passes, and the changed `TestNMTimelinePublisher` tests pass (6/6). Yetus reports two NodeManager failures that appear unrelated to this patch: > > * **SpotBugs:** Trunk has one existing `NP_NULL_ON_SOME_PATH_EXCEPTION` warning in `ResourceLocalizationService$PublicLocalizer.run()`; this patch adds no new warnings. [YARN-11993](https://issues.apache.org/jira/browse/YARN-11993) / [PR #8755](https://github.com/apache/hadoop/pull/8755) addresses it. > * **Unit test:** `TestLogAggregationService.testLocalFileDeletionAfterUpload` fails because the application log directory still exists when asserted. The test waits for individual files, but not for the independently scheduled directory deletion. This failed on all three attempts in this run. [HADOOP-19979](https://issues.apache.org/jira/browse/HADOOP-19979) / [PR #8717](https://github.com/apache/hadoop/pull/8717) adds the missing wait. > > Neither failing path is changed by this PR. Once those fixes land, a fresh CI run should establish whether any failures remain. @gerashegalov Thanks for inviting me to review this PR! I'll take another look. I suggest merging #8776 and #8779 first, as they address unrelated flaky YARN tests that can cause CI failures. This should help stabilize the CI baseline and make it easier to assess this PR's results. Thanks for your patience! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
