[ 
https://issues.apache.org/jira/browse/HADOOP-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415793#comment-13415793
 ] 

Chuan Liu commented on HADOOP-8453:
-----------------------------------

HADOOP-8601 is created to track JUnit for Windows shell commands.

{quote}
We need to make sure these tests are executed on Windows. One option would be 
to check for that at startup of the test and return success for other OS's.
{quote}

The Ant task uses 'if windows' to only execute the test if 'windows' is set to 
'true'. This is on par with 'winutils' build task. Cmd batch scripts are not 
support on Linux. So I don't think we can check OS's inside the scripts. This 
is also true for other Linux only test scripts, e.g. test-libhdfs.sh.
                
> Add unit tests for winutils
> ---------------------------
>
>                 Key: HADOOP-8453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8453
>             Project: Hadoop Common
>          Issue Type: Task
>          Components: test
>    Affects Versions: 1.1.0, 0.24.0
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>            Priority: Minor
>         Attachments: HADOOP-8453-branch-1-win-2.patch, 
> HADOOP-8453-branch-1-win.patch
>
>
> In [Hadoop-8235|https://issues.apache.org/jira/browse/HADOOP-8235], we 
> created a Windows console program, named ‘winutils’, to emulate some Linux 
> command line utilities used by Hadoop. However no tests are provided in the 
> original patch. As this code is quite complicated, and the complexity may 
> even grow up in the future. We think unit tests are necessary to ensure code 
> quality, as well as smooth future development.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to