[ https://issues.apache.org/jira/browse/HADOOP-7967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416574#comment-13416574 ]
Hadoop QA commented on HADOOP-7967: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12536854/HADOOP-7967.newapi.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified test files. -1 javac. The applied patch generated 2074 javac compiler warnings (more than the trunk's current 2067 warnings). +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: org.apache.hadoop.fs.TestFilterFileSystem org.apache.hadoop.ha.TestZKFailoverController org.apache.hadoop.io.file.tfile.TestTFileByteArrays org.apache.hadoop.io.file.tfile.TestTFileJClassComparatorByteArrays org.apache.hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS org.apache.hadoop.hdfs.TestPersistBlocks +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1199//testReport/ Javac warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/1199//artifact/trunk/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1199//console This message is automatically generated. > Need generalized multi-token filesystem support > ----------------------------------------------- > > Key: HADOOP-7967 > URL: https://issues.apache.org/jira/browse/HADOOP-7967 > Project: Hadoop Common > Issue Type: Bug > Components: fs, security > Affects Versions: 0.23.1, 0.24.0 > Reporter: Daryn Sharp > Assignee: Daryn Sharp > Attachments: HADOOP-7967-2.patch, HADOOP-7967-3.patch, > HADOOP-7967-4.patch, HADOOP-7967-compat.patch, HADOOP-7967.newapi.patch, > HADOOP-7967.patch > > > Multi-token filesystem support and its interactions with the MR > {{TokenCache}} is problematic. The {{TokenCache}} tries to assume it has the > knowledge to know if the tokens for a filesystem are available, which it > can't possibly know for multi-token filesystems. Filtered filesystems are > also problematic, such as har on viewfs. When mergeFs is implemented, it too > will become a problem with the current implementation. Currently > {{FileSystem}} will leak tokens even when some tokens are already present. > The decision for token acquisition, and which tokens, should be pushed all > the way down into the {{FileSystem}} level. The {{TokenCache}} should be > ignorant and simply request tokens from each {{FileSystem}}. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira