[
https://issues.apache.org/jira/browse/HADOOP-19982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18125082#comment-18125082
]
ASF GitHub Bot commented on HADOOP-19982:
-----------------------------------------
hadoop-yetus commented on PR #8725:
URL: https://github.com/apache/hadoop/pull/8725#issuecomment-6062348959
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 36s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 3 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 2m 25s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 44m 18s | | trunk passed |
| +1 :green_heart: | compile | 16m 9s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | compile | 16m 25s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | checkstyle | 5m 33s | | trunk passed |
| +1 :green_heart: | mvnsite | 19m 0s | | trunk passed |
| +1 :green_heart: | javadoc | 9m 56s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 9m 42s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| -1 :x: | spotbugs | 35m 20s |
[/branch-spotbugs-root-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8725/9/artifact/out/branch-spotbugs-root-warnings.html)
| root in trunk has 80 extant spotbugs warnings. |
| +1 :green_heart: | shadedclient | 30m 13s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 37m 55s | | the patch passed |
| +1 :green_heart: | compile | 16m 3s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javac | 16m 3s | | the patch passed |
| +1 :green_heart: | compile | 16m 22s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | javac | 16m 22s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 5m 49s |
[/results-checkstyle-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8725/9/artifact/out/results-checkstyle-root.txt)
| root: The patch generated 1 new + 128 unchanged - 1 fixed = 129 total (was
129) |
| +1 :green_heart: | mvnsite | 18m 46s | | the patch passed |
| +1 :green_heart: | javadoc | 9m 56s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 9m 47s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | spotbugs | 43m 3s | | the patch passed |
| +1 :green_heart: | shadedclient | 63m 1s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 760m 58s | | root in the patch passed. |
| +1 :green_heart: | asflicense | 2m 0s | | The patch does not
generate ASF License warnings. |
| | | 1149m 59s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.56 ServerAPI=1.56 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8725/9/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/8725 |
| Optional Tests | dupname asflicense codespell detsecrets compile javac
javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle |
| uname | Linux 6b2d050786b8 5.15.0-186-generic #196-Ubuntu SMP Sat Jun 20
16:09:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 9492c0711010248cd5ca7f2db261b376bff7e892 |
| Default Java | Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Multi-JDK versions |
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8725/9/testReport/ |
| Max. process+thread count | 3696 (vs. ulimit of 10000) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-client
hadoop-hdfs-project/hadoop-hdfs . U: . |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8725/9/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.7 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
> Re-enable TestDFSClientRetries and TestBalancerWithHANameNodes in GHA
> ---------------------------------------------------------------------
>
> Key: HADOOP-19982
> URL: https://issues.apache.org/jira/browse/HADOOP-19982
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: common, hdfs, test
> Reporter: Jose Luis López
> Assignee: Jose Luis López
> Priority: Major
> Labels: pull-request-available
>
> h3. What
> Remove two entries from \{{.github/gha-tests/exclude-tests.txt}}:
> * \{{**/org/apache/hadoop/hdfs/TestDFSClientRetries.java}}
> *
> \{{**/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithHANameNodes.java}}
> h3. Why these two
> *TestDFSClientRetries* - fixed by HDFS-17972.
> {\{testLeaseRenewAndDFSOutputStreamDeadLock}} installed a
> {\{DFSClientFaultInjector}} whose \{{delayWhenRenewLeaseTimeout()}} blocked
> on an
> unbounded \{{testLatch.await()}}, and never restored the previous injector. If
> the test died before \{{NameNode.complete()}} counted the latch down, a lease
> renewer thread stayed parked inside the injector holding the \{{LeaseRenewer}}
> monitor. That hung the rest of the class until Surefire killed the fork,
> losing
> the class's results - exactly the "fails or aborts" the README describes. The
> fix bounds the wait at 30s and both counts the latch down and restores the
> injector in a \{{finally}} block. All 13 tests in the class already shut their
> clusters down in \{{finally}}.
> *TestBalancerWithHANameNodes* - fixed by HDFS-17957.
> {\{testBalancerWithHANameNodes}} and \{{testBalancerRequestSBNWithHA}} ran on
> a
> 60s budget when \{{waitStoragesNoStale}} alone can legitimately consume 60s,
> so
> the deadline could fire before the balancer even started on a loaded agent.
> Both are now 300s. The same change removed dead code that pinned the default
> NameNode RPC port.
> h3. Risk
> Both classes run in the \{{hdfs - other}} matrix entry
> (\{{-pl :hadoop-hdfs -DexcludedGroups=slow}}); neither carries
> \{{@Tag("slow")}},
> so one matrix entry exercises both removals. Neither class is excluded
> anywhere
> else in the repository. Since HDFS-17957 set
> {\{junit.jupiter.execution.timeout.default}} to 600s for this module, a
> regression in either class surfaces as a named test failure rather than a lost
> fork, so the cost of getting this wrong is one red test, not one red job.
> h3. Acceptance criteria
> Five consecutive successful GHA runs with both entries removed, per
> {\{.github/gha-tests/README.md}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
