joseluisll commented on code in PR #8812: URL: https://github.com/apache/hadoop/pull/8812#discussion_r4244865270
########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/MachineList.java: ########## Review Comment: Nit: parse the prefix once and move the validation before using the data. Integer.parseInt(prefix) runs twice L83 and L87 slash and prefix L76-L77 are computed before the validation in L80. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
