[
https://issues.apache.org/jira/browse/HADOOP-7856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18126792#comment-18126792
]
ASF GitHub Bot commented on HADOOP-7856:
----------------------------------------
sankalpsthakur commented on PR #8746:
URL: https://github.com/apache/hadoop/pull/8746#issuecomment-6150056990
javadoc-only change so no new tests, the spotbugs -1 is the existing trunk
warning and the patch run passes spotbugs, ptal
> Improve DiskChecker javadocs
> ----------------------------
>
> Key: HADOOP-7856
> URL: https://issues.apache.org/jira/browse/HADOOP-7856
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Reporter: Eli Collins
> Priority: Major
> Labels: newbie, pull-request-available
>
> The javadocs for DiskChecker#checkDir(File dir) trail off, look like they
> weren't completed, should be.
> While checkDir(File) uses java File to check if a dir actually is writable,
> the version of checkDir that takes an FsPermission uses FsAction#implies
> which doesn't actually check if a dir is writable (eg it passes on a
> read-only file system). So switching from one version to the other can cause
> unexpected bugs. Let's call this out explicitly in the javadocs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
