joseluisll commented on PR #8805:
URL: https://github.com/apache/hadoop/pull/8805#issuecomment-6203461837
Pushed two small changes:
- Both ExpiredTokenRemover tests in TestDelegationToken now call
`ExitUtil.enableSystemExit()` in their `finally` blocks, so the
disabled-exit state doesn't leak into later tests in the class.
`TestZKDelegationTokenSecretManager` intentionally keeps exit disabled
for the whole class: re-enabling it after each test would let a leaked
remover thread kill the fork again, which is what this PR fixes.
- Dropped the try/finally around `super.tearDown()` in the RBF
`TestZKDelegationTokenSecretManagerImpl`. It was only needed while the
ExitUtil check lived in `tearDown()`. Since that check moved to its own
`@AfterEach`, it's plain resource cleanup, so I moved it to #8806
(HADOOP-20011).
I checked this together with #8806 and #8688 (HADOOP-19966). All three
merge cleanly in any order. With #8688, a failed `startThreads()` calls
`stopThreads()` before the remover thread exists, so it never reaches the
new `!running` path here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
