smengcl opened a new pull request, #8843: URL: https://github.com/apache/hadoop/pull/8843
Generated-by: Claude Code (Opus 5.5) ### Description of PR `DFSUtilClient.getNNUri`, `DFSUtil.substituteForWildcardAddress` and `GetConf -nnRpcAddresses` built a URI or `host:port` string from `getHostName()` and the port. For an IPv6 address with no PTR record, `getHostName()` returns the unbracketed literal, so `hdfs://2001:db8:0:0:0:0:0:10:8021` parses with a null host and `http://2001:db8:0:0:0:0:0:11:9870` fails in `toURL()`. This can stop the NameNode (trash emptier, standby services) and breaks `refresh-namenodes.sh`. All three now use `NetUtils.getHostPortString`, which brackets IPv6 literals. `getNNUri` still omits the default RPC port. Hostname and IPv4 output is unchanged. ### How was this patch tested? Added IPv6 cases to `TestDefaultNameNodePort#testGetUriIPv6`, `TestDFSUtil#testSubstituteForWildcardAddress` and `TestGetConf#testNonFederation` (the `TestGetConf` helper that builds the expected `host:port` now uses `NetUtils.getHostPortString` too). `TestDefaultNameNodePort`, `TestDFSUtil` and `TestGetConf` pass locally. ### For code changes: - [x] Does the title of this PR start with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: Have the integration tests been executed and the endpoint declared according to the connector-specific documentation? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? ### AI Tooling - [x] The PR includes the phrase "Contains content generated by Claude Code" - [x] My use of AI contributions follows the ASF legal policy https://www.apache.org/legal/generative-tooling.html Contains content generated by Claude Code. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
