smengcl opened a new pull request, #8851:
URL: https://github.com/apache/hadoop/pull/8851
Generated-by: Claude Code (Opus 5.5)
### Description of PR
`DataTransferSaslUtil.getPeerAddress` took the host from
`Peer.getRemoteAddressString()` with `split(":")[0]`. For an IPv6 peer the
string is `/[fd00:dead:beef::21]:9866` (or `/0:0:0:0:0:0:0:1:9866` before JDK
14), so the split gives `/[fd00` and `InetAddresses.forString` throws
`IllegalArgumentException: '[fd00' is not an IP string literal`.
`SaslDataTransferClient` and `SaslDataTransferServer` call it for the
trusted channel check and SASL negotiation, so with data transfer protection
enabled, client reads from an IPv6 DataNode fail.
This PR strips the port after the last colon, drops the `host/` prefix, then
removes IPv6 brackets before calling `InetAddresses.forString`. IPv4 and
`host/ip:port` forms parse as before.
Part of HDFS-18009.
### How was this patch tested?
Added `TestSaslDataTransfer#testGetPeerAddress`, covering
`InetSocketAddress#toString` output for IPv4, IPv6 and IPv6 loopback (with and
without a host name), plus the unbracketed `/0:0:0:0:0:0:0:1:9866`,
`[::1]:9866` and plain `ip:port` forms, and a host name without an IP (still
rejected). Without the main change the test fails with the exception above.
`TestSaslDataTransfer` passes locally with JDK 17.
### For code changes:
- [x] Does the title of this PR start with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: Have the integration tests been executed and the
endpoint
declared according to the connector-specific documentation? *Note:
Automated CI
testing doesn't cover all cases so manual testing with cloud storage
is still
required.*
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
### AI Tooling
Contains content generated by Claude Code.
- [x] The PR includes the phrase "Contains content generated by <tool>"
where <tool> is the name of the AI tool used.
- [x] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
