smengcl opened a new pull request, #8855:
URL: https://github.com/apache/hadoop/pull/8855
Generated-by: Claude Code (Opus 5.5)
### Description of PR
With `hadoop.security.token.service.use_ip=false`,
`SecurityUtil.getByName("[2001:db8::1]")` throws `UnknownHostException`, while
with `use_ip=true` it returns the address. `QualifiedHostResolver.resolve` did
not recognize the bracketed form as an IP literal and sent it down the host
name and search domain path, where the JDK rejects it.
`URI.getHost()` returns IPv6 hosts in brackets, so callers such as
`DelegationTokenSelector.selectToken` (via `NetUtils.createSocketAddrForHost`)
and `NetUtils.getCanonicalUri` pass that form on.
This strips the brackets in `QualifiedHostResolver.resolve` when the input
is a bracketed IPv6 literal (`InetAddresses.isUriInetAddress`), so both
resolvers give the same result. IPv4 addresses and host names are unchanged,
and a bracketed IPv4 literal such as `[127.0.0.1]` is still rejected, as the
JDK does.
### How was this patch tested?
- New `TestSecurityUtil#testGetByNameWithBracketedIPv6`: resolves `[::1]`
and `[2001:db8::1]` with `use_ip` false and true, and checks that `[127.0.0.1]`
is rejected in both modes. Fails on trunk with `UnknownHostException: [::1]`.
- `TestSecurityUtil` and `TestNetUtils` pass.
### For code changes:
- [x] Does the title of this PR start with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: Have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
### AI Tooling
- [x] The PR includes the phrase "Contains content generated by Claude Code".
- [x] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
Contains content generated by Claude Code.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
