[ 
https://issues.apache.org/jira/browse/HADOOP-17611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18132161#comment-18132161
 ] 

ASF GitHub Bot commented on HADOOP-17611:
-----------------------------------------

hadoop-yetus commented on PR #8858:
URL: https://github.com/apache/hadoop/pull/8858#issuecomment-6408295885

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |  18m 51s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 3 new or modified test files.  |
   |||| _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  49m 55s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   0m 53s |  |  trunk passed with JDK 
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu  |
   | +1 :green_heart: |  compile  |   0m 53s |  |  trunk passed with JDK 
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu  |
   | +1 :green_heart: |  checkstyle  |   0m 51s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   0m 55s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   0m 52s |  |  trunk passed with JDK 
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu  |
   | +1 :green_heart: |  javadoc  |   0m 50s |  |  trunk passed with JDK 
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu  |
   | -1 :x: |  spotbugs  |   1m 16s | 
[/branch-spotbugs-hadoop-tools_hadoop-distcp-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8858/2/artifact/out/branch-spotbugs-hadoop-tools_hadoop-distcp-warnings.html)
 |  hadoop-tools/hadoop-distcp in trunk has 21 extant spotbugs warnings.  |
   | +1 :green_heart: |  shadedclient  |  34m 59s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | -1 :x: |  mvninstall  |   0m 25s | 
[/patch-mvninstall-hadoop-tools_hadoop-distcp.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8858/2/artifact/out/patch-mvninstall-hadoop-tools_hadoop-distcp.txt)
 |  hadoop-distcp in the patch failed.  |
   | -1 :x: |  compile  |   0m 24s | 
[/patch-compile-hadoop-tools_hadoop-distcp-jdkUbuntu-21.0.12.1+1-1-24.04.4-Ubuntu.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8858/2/artifact/out/patch-compile-hadoop-tools_hadoop-distcp-jdkUbuntu-21.0.12.1+1-1-24.04.4-Ubuntu.txt)
 |  hadoop-distcp in the patch failed with JDK 
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu.  |
   | -1 :x: |  javac  |   0m 24s | 
[/patch-compile-hadoop-tools_hadoop-distcp-jdkUbuntu-21.0.12.1+1-1-24.04.4-Ubuntu.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8858/2/artifact/out/patch-compile-hadoop-tools_hadoop-distcp-jdkUbuntu-21.0.12.1+1-1-24.04.4-Ubuntu.txt)
 |  hadoop-distcp in the patch failed with JDK 
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu.  |
   | -1 :x: |  compile  |   0m 25s | 
[/patch-compile-hadoop-tools_hadoop-distcp-jdkUbuntu-17.0.20.1+1-1-24.04-Ubuntu.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8858/2/artifact/out/patch-compile-hadoop-tools_hadoop-distcp-jdkUbuntu-17.0.20.1+1-1-24.04-Ubuntu.txt)
 |  hadoop-distcp in the patch failed with JDK 
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu.  |
   | -1 :x: |  javac  |   0m 25s | 
[/patch-compile-hadoop-tools_hadoop-distcp-jdkUbuntu-17.0.20.1+1-1-24.04-Ubuntu.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8858/2/artifact/out/patch-compile-hadoop-tools_hadoop-distcp-jdkUbuntu-17.0.20.1+1-1-24.04-Ubuntu.txt)
 |  hadoop-distcp in the patch failed with JDK 
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu.  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 19s |  |  the patch passed  |
   | -1 :x: |  mvnsite  |   0m 26s | 
[/patch-mvnsite-hadoop-tools_hadoop-distcp.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8858/2/artifact/out/patch-mvnsite-hadoop-tools_hadoop-distcp.txt)
 |  hadoop-distcp in the patch failed.  |
   | +1 :green_heart: |  javadoc  |   0m 22s |  |  the patch passed with JDK 
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu  |
   | +1 :green_heart: |  javadoc  |   0m 20s |  |  the patch passed with JDK 
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu  |
   | -1 :x: |  spotbugs  |   0m 24s | 
[/patch-spotbugs-hadoop-tools_hadoop-distcp.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8858/2/artifact/out/patch-spotbugs-hadoop-tools_hadoop-distcp.txt)
 |  hadoop-distcp in the patch failed.  |
   | +1 :green_heart: |  shadedclient  |  36m 27s |  |  patch has no errors 
when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | -1 :x: |  unit  |   0m 28s | 
[/patch-unit-hadoop-tools_hadoop-distcp.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8858/2/artifact/out/patch-unit-hadoop-tools_hadoop-distcp.txt)
 |  hadoop-distcp in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 36s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 150m 33s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.56 ServerAPI=1.56 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8858/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8858 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux 5fc053db0853 5.15.0-190-generic #200-Ubuntu SMP Fri Aug 7 
15:06:04 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 1d2390aeb59a2c46d0bb8bcc165e3bf78fb1949d |
   | Default Java | Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
   | Multi-JDK versions | 
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu 
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8858/2/testReport/ |
   | Max. process+thread count | 583 (vs. ulimit of 10000) |
   | modules | C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8858/2/console |
   | versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.7 |
   | Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Distcp parallel file copy breaks the modification time
> ------------------------------------------------------
>
>                 Key: HADOOP-17611
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17611
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Adam Maroti
>            Assignee: Adam Maroti
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> The commit HADOOP-11794. Enable distcp to copy blocks in parallel. 
> (bf3fb585aaf2b179836e139c041fc87920a3c886) broke the modification time of 
> large files.
>  
> In CopyCommitter.java inside concatFileChunks Filesystem.concat is called 
> which changes the modification time therefore the modification times of files 
> copeid by distcp will not match the source files. However this only occurs 
> for large enough files, which are copied by splitting them up by distcp.
> In concatFileChunks before calling concat extract the modification time and 
> apply that to the concatenated result-file after the concat. (probably best 
> -after- before the rename()).



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to