Abhi0505-kinagi commented on PR #8864: URL: https://github.com/apache/hadoop/pull/8864#issuecomment-6414906040
@pan3793, I reproduced the mvninstall failure for hadoop-yarn-capacity-scheduler-ui locally (Node 22.16.0, npm 10.9.2). Root cause: vitest 5.0.5 declares peerOptional @types/node@"^22.0.0 || >=24.0.0", but the module pins @types/node@^20, so npm ci fails with ERESOLVE. After that, tsc reports 835 missing-matcher errors in test files until the jest-dom import in vitest-setup.ts changes to @testing-library/jest-dom/vitest. Fix: bump @types/node to ^22 and change that one import. With both, typecheck, lint, 92 test files / 1522 tests, and the build all pass. Is a JIRA needed for this, or can I open a PR directly against trunk? I’ll link the PR here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
