joseluisll commented on PR #8841: URL: https://github.com/apache/hadoop/pull/8841#issuecomment-6533666607
Thanks @pjfanning. Addressed in the latest commit: - **Wrapping and mapper races:** the provider now builds its mappers once, with a separate one for `TimelineAbout`. Two details differ from what you described. Jackson caches writers per type and annotations, so only types first written after `/about` get wrapped. And the put reader doesn't throw, because `TimelinePutResponse` ignores unknown fields: the client silently saw zero errors. The new test writes `/about` first on a fresh provider, because an earlier put on a shared server would hide the bug. - **Test parity:** `TestTimelineWebServices` now matches `configure()`. That exposed a separate bug: clients decoded every put error as `id=null, code=0`. `TimelinePutError` now accepts both spellings. - **Scans:** both removed. - **Docs:** `TimelineServer.md` updated, and the release note goes on the JIRA. `JAXBContextResolver` has no audience annotation, so I've kept it removed and will mention it there. - **Entity writers:** this is real and wider than the shape difference. Documented entity JSON is rejected with a 400, and those classes are shared with the clients, so I'd like to handle it in a separate JIRA with its own compatibility review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
