[
https://issues.apache.org/jira/browse/HADOOP-20057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18137926#comment-18137926
]
ASF GitHub Bot commented on HADOOP-20057:
-----------------------------------------
pan3793 commented on PR #8921:
URL: https://github.com/apache/hadoop/pull/8921#issuecomment-6628574523
Thanks for the cleanup. Two small additions would complete it:
1. `hadoop-tools/hadoop-sls/src/test/resources/ongoing-invariants.txt:51-54`
still has the `LogFatal/LogError/LogWarn/LogInfo >= 0` invariants. YARN-10750
removed the same lines from the RM's `invariants.txt` and
`invariants_jdk9.txt`, but missed this file. The SLS tests are skipped today
because JDK 17 has no JavaScript engine, so this is dormant, but the unbound
names should fail the check once an engine is available. Please delete these
four lines.
2. The class Javadoc in `JvmMetricsInfo.java:27` and `JvmMetrics.java:49`
still says "JVM and logging related metrics". Please drop "and logging".
The rest looks good to me. The enum constants have no remaining references,
and the removed findbugs exclusions match classes deleted by HADOOP-17524 and
HADOOP-12504.
> Remove leftover Log* JVM metrics and EventCounter references after
> HADOOP-17524
> -------------------------------------------------------------------------------
>
> Key: HADOOP-20057
> URL: https://issues.apache.org/jira/browse/HADOOP-20057
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common, metrics
> Reporter: dzcxzl
> Priority: Minor
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
