joseluisll commented on PR #8893:
URL: https://github.com/apache/hadoop/pull/8893#issuecomment-6658549640
Thanks @pan3793, all done in the new head:
1. `MultiException` is gone from `HttpServer2`. The `start()` catch was
redundant as you said (the outer `catch (Exception e)` wraps it), so it is
removed. `stop()` now collects into a `List<Exception>`: nothing recorded means
no throw, one is rethrown as it is, and with several the first is thrown
carrying the rest as suppressed. That keeps the single-failure behaviour your
first inline comment was about, and `HttpServer2` no longer imports the type.
2. You're right about the sentence, and I checked the 12.1.14 jars:
`RequestLogHandler` is gone, and `WebSocketServlet`/`WebSocketServletFactory`
become
`ee8.websocket.server.JettyWebSocketServlet`/`JettyWebSocketServletFactory`. I
also found `HandlerCollection` → `ee8.nested.HandlerCollection` and
`server.session.SessionHandler` → `org.eclipse.jetty.session.SessionHandler`.
The PR description and the JIRA now say that, and those are left to
HADOOP-19972.
Inline comments: `checkEvents` now throws
`MultipleFailuresError("checkEvents", failures)`, so a single failure shows its
assertion message again; `inferMimeType` returns `getMimeType(path)` directly;
the duplicate blank lines and the `org.slf4j` import order are fixed in the six
and three files you named.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
