[
https://issues.apache.org/jira/browse/HADOOP-20015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18137963#comment-18137963
]
ASF GitHub Bot commented on HADOOP-20015:
-----------------------------------------
joseluisll commented on PR #8893:
URL: https://github.com/apache/hadoop/pull/8893#issuecomment-6630494014
Thanks @pan3793, good suggestion. I've regrouped the two PRs by kind of
change, each covering the whole repository:
- #8893 (HADOOP-20015) has only the Java changes: Jetty APIs that Jetty 12
removes, replaced by the JDK, SLF4J or the servlet API. That's Jetty's `Log` in
8 test files across hadoop-common and YARN, the `ConcurrentHashSet` in
`FederationInterceptor`, the borrowed logger in `TestDockerCommandExecutor`,
and the Jetty cast in `HttpServer2#inferMimeType`. A sweep of the repo also
found `MultiException` in `TestLogAggregationService`, now a plain list of
failures. Every other Jetty class the code imports still exists in Jetty 12, or
moves to the ee8 packages, which belongs to the upgrade itself (HADOOP-19972).
- #8894 (HADOOP-20016) has only the pom changes: each module declares the
Jetty artifacts it imports directly, at the scope it already resolves them at.
The same sweep added a few more modules (hdfs, httpfs, jobclient, NodeManager,
Router, web-proxy). The per-module Jetty dependency lists are the same before
and after.
Neither PR depends on the other.
> Stop using Jetty 9.4 APIs that Jetty 12 removes
> -----------------------------------------------
>
> Key: HADOOP-20015
> URL: https://issues.apache.org/jira/browse/HADOOP-20015
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Jose Luis López
> Assignee: Jose Luis López
> Priority: Major
> Labels: pull-request-available
>
> *Scope*: every use, in main and test code across the repository, of a Jetty
> 9.4 class that Jetty 12 no longer has, where the JDK, SLF4J or the servlet
> API does the same job:
> * FSMainOperationsBaseTest, ViewFileSystemTestSetup, ViewFsTestSetup,
> TestAuthenticationSessionCookie (hadoop-common),
> TestRollingLevelDBTimelineStore (applicationhistoryservice), TestAMRMClient,
> TestYarnCLI (yarn-client) and MockNM (resourcemanager): they logged through
> org.eclipse.jetty.util.log.Log, which Jetty 10 and later no longer have. Log
> through SLF4J instead.
> * TestDockerCommandExecutor (nodemanager): it borrowed a logger from Jetty's
> GzipHttpOutputInterceptor. Give it its own.
> * FederationInterceptor (nodemanager): replace Jetty's ConcurrentHashSet,
> which Jetty 12 no longer has, with ConcurrentHashMap.newKeySet().
> * TestLogAggregationService (nodemanager): it batched assertion failures in
> Jetty's MultiException, which Jetty 12 no longer has. Collect them in a list
> and throw one AssertionError carrying all of them.
> * HttpServer2#inferMimeType (hadoop-common): drop the cast to a Jetty
> context, since ServletContext has getMimeType.
> *Out of scope*: classes that Jetty 12 moves to the org.eclipse.jetty.ee8
> packages, and uses whose only replacement is another Jetty API (such as
> MultiException in HttpServer2). Those are the upgrade itself, HADOOP-19972.
> Every other Jetty class the code imports still exists in Jetty 12.
> *Why*: these uses would not compile on Jetty 12, and none of them needs
> Jetty. Removing them now keeps HADOOP-19972 to the changes the upgrade really
> requires.
> *Impact on Jetty 9*: none. Java changes only, no pom change; the logging,
> set, failure-batching and MIME-type code behaves the same.
> *Downstream*: none.
> *CI*: hadoop-common, applicationhistoryservice, yarn-client, resourcemanager,
> nodemanager.
> *PR*: https://github.com/apache/hadoop/pull/8893
> Regrouped on 2026-11-04 by kind of change, as suggested in the review: this
> issue now holds all the Java changes that were split between HADOOP-20015
> (YARN) and HADOOP-20016 (HADOOP); HADOOP-20016 holds all the pom changes.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
