[
https://issues.apache.org/jira/browse/HADOOP-20007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18139324#comment-18139324
]
ASF GitHub Bot commented on HADOOP-20007:
-----------------------------------------
hadoop-yetus commented on PR #8949:
URL: https://github.com/apache/hadoop/pull/8949#issuecomment-6675158699
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 25s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 2 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 31m 14s | | trunk passed |
| +1 :green_heart: | compile | 10m 26s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | compile | 10m 46s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | checkstyle | 0m 54s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 10s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 50s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 0m 49s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | spotbugs | 1m 50s | | trunk passed |
| +1 :green_heart: | shadedclient | 20m 50s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 48s | | the patch passed |
| +1 :green_heart: | compile | 10m 24s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javac | 10m 24s | | the patch passed |
| +1 :green_heart: | compile | 10m 27s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | javac | 10m 27s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 46s | | the patch passed |
| +1 :green_heart: | mvnsite | 1m 11s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 47s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 0m 50s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | spotbugs | 1m 52s | | the patch passed |
| +1 :green_heart: | shadedclient | 21m 23s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 17m 31s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 36s | | The patch does not
generate ASF License warnings. |
| | | 146m 46s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.56 ServerAPI=1.56 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8949/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/8949 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux d78e325560c8 5.15.0-190-generic #200-Ubuntu SMP Fri Aug 7
15:06:04 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 3d9a9eed618dc85c4d60172dd97262d07e84f552 |
| Default Java | Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Multi-JDK versions |
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8949/1/testReport/ |
| Max. process+thread count | 1277 (vs. ulimit of 10000) |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8949/1/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.7 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
> Add tests for the javax.servlet contract and HTTP behaviour offered to
> downstream projects
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-20007
> URL: https://issues.apache.org/jira/browse/HADOOP-20007
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: common, test
> Reporter: Jose Luis López
> Priority: Minor
> Labels: pull-request-available
>
> HBase, Hive, Spark, Ozone and Knox compile against hadoop-auth's filters and
> {{HttpServer2}}. HADOOP-19912 moves Hadoop to Jetty 12 on the ee8 environment
> so that this API keeps {{javax.servlet}} and downstream projects need not
> rebuild. That promise should be enforced by a test, not left to review.
> h3. Changes
> New {{TestDownstreamServletCompatibility}} in hadoop-common, which:
> * checks reflectively that the public and protected signatures of that API
> name only {{javax.servlet}} types, with no {{jakarta.servlet}} and no
> {{org.eclipse.jetty}};
> * runs a downstream-style filter and servlet on an {{HttpServer2}} and checks
> the response.
> New tests in {{TestHttpServer}} pin behaviour a Jetty upgrade could change
> silently:
> * a redirect's {{Location}} is absolute;
> * {{/static}} lists no directory;
> * paths with an empty segment, an encoded percent or an encoded backslash
> reach the servlet;
> * {{/logs}} keeps its admin check when {{hadoop.log.dir}} is missing.
> {{HttpServer2}} sets {{relativeRedirectAllowed}} to false explicitly. That is
> Jetty 9.4's default, so nothing changes today; Jetty 12's default is true.
> The tests pass on trunk (Jetty 9.4), and HADOOP-19972 must keep them green.
> It is expected to fail on the day the jakarta move (HADOOP-19395) reaches
> this API, which belongs to a major release.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
