pan3793 commented on code in PR #8688:
URL: https://github.com/apache/hadoop/pull/8688#discussion_r4488917193
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/ZKDelegationTokenSecretManager.java:
##########
@@ -386,6 +433,24 @@ private void loadFromZKCache(final boolean isTokenCache) {
LOG.info("Loaded {} cache.", cacheName);
}
+ private void awaitCacheInitialized(CountDownLatch initialized,
+ String cacheName) throws IOException {
+ try {
+ if (cacheInitTimeoutMs > 0) {
+ if (!initialized.await(cacheInitTimeoutMs, TimeUnit.MILLISECONDS)) {
+ throw new IOException("Timed out after " + cacheInitTimeoutMs
+ + " ms waiting for " + cacheName + " cache initialization");
+ }
+ } else {
+ initialized.await();
Review Comment:
Done in a9b7b35: a WARN every 60s while waiting, with the configured timeout
in the message. The Javadoc also notes that CuratorCache counts a failed
initial read as done.
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/ZKDelegationTokenSecretManager.java:
##########
@@ -301,9 +334,11 @@ public void startThreads() throws IOException {
}
})
.forDeletes(childData -> processKeyRemoved(childData.getPath()))
+ .forInitialized(keyCacheInitialized::countDown)
Review Comment:
Superseded in a9b7b35: the listener now applies the initial nodes and
`loadFromZKCache` is removed, so nothing is decoded twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
