joseluisll commented on PR #8894:
URL: https://github.com/apache/hadoop/pull/8894#issuecomment-6628265934
Thanks @pan3793 for the review.
The version pin you suggest is already in this PR: `hadoop-project/pom.xml`
now manages `jetty-http` at `${jetty.version}` in `dependencyManagement`.
The module declarations exist because `HttpServer2`,
`ShuffleChannelHandler`, `TestJettyHelper` (HttpFS) and `SLSWebApp` import
`org.eclipse.jetty.http.*` directly, but only get it through `jetty-server`. My
main concern was not to change what downstream projects resolve. That's why
they are `optional` (`provided` in hadoop-sls):
- With `optional`, downstream resolution is identical to trunk. I compared
the dependency trees of sample downstream projects to check this.
- At plain compile scope it was not. A project with `jetty-client` 9.4.40
next to `hadoop-common` resolved `jetty-http` 9.4.58 instead of 9.4.40, because
Maven's nearest-wins picked Hadoop's declaration.
The declarations aren't strictly needed for the Jetty 12 port, though:
`jetty-server` 12 still brings `jetty-http`. If you prefer, I'll drop them and
keep only the `dependencyManagement` entry and the Log/context-cast cleanup.
Downstream resolution stays the same either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
