[
https://issues.apache.org/jira/browse/HADOOP-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422583#comment-13422583
]
Todd Lipcon commented on HADOOP-8621:
-------------------------------------
Hey Robert. Thanks for noticing the bug and the fix. It looks good to me.
Would you mind adding a simple unit test in
./src/test/java/org/apache/hadoop/fs/TestFileUtil.java? It seems like it should
be trivial to mkdir a directory with a space in the path and try to create a
symlink.
Also, when you generate a patch, best to generate it relative to the SVN root
so the automatic patch tester can build it. Thanks!
> FileUtil.symLink fails if spaces in path
> ----------------------------------------
>
> Key: HADOOP-8621
> URL: https://issues.apache.org/jira/browse/HADOOP-8621
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Robert Fuller
> Priority: Minor
> Attachments: patch.txt
>
>
> the 'ln -s' command fails in the current implementation if there is a space
> in the path for the target or linkname. A small change resolves the issue.
> String cmd = "ln -s " + target + " " + linkname;
> //Process p = Runtime.getRuntime().exec(cmd, null); //broken
> Process p = Runtime.getRuntime().exec(new
> String[]{"ln","-s",target,linkname}, null);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
