[ https://issues.apache.org/jira/browse/HADOOP-8624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422937#comment-13422937 ]
Aaron T. Myers commented on HADOOP-8624: ---------------------------------------- +1, the patch looks good to me. I'm confident that the test failure is unrelated. The javadoc warning is a little curious, though. Any explanation for that? > ProtobufRpcEngine should log all RPCs if TRACE logging is enabled > ----------------------------------------------------------------- > > Key: HADOOP-8624 > URL: https://issues.apache.org/jira/browse/HADOOP-8624 > Project: Hadoop Common > Issue Type: Improvement > Components: ipc > Affects Versions: 3.0.0, 2.2.0-alpha > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Priority: Minor > Attachments: hadoop-8624.txt > > > Since all RPC requests/responses are now ProtoBufs, it's easy to add a TRACE > level logging output for ProtobufRpcEngine that actually shows the full > content of all calls. This is very handy especially when writing/debugging > unit tests, but might also be useful to enable at runtime for short periods > of time to debug certain production issues. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira