[ 
https://issues.apache.org/jira/browse/HADOOP-8480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426819#comment-13426819
 ] 

Andy Isaacson commented on HADOOP-8480:
---------------------------------------

That's a pretty awful hack, but there's no better way AFAIK.  LGTM.  Patch .002 
should work for all shells.

It does break for certain evil values, if the user specifies {{-DskipTests="foo 
bar"}} I think the shell expansion will throw an error and we will run the 
tests.  Which is, sort of, what the user asked for, so I think it's OK.
                
> The native build should honor -DskipTests
> -----------------------------------------
>
>                 Key: HADOOP-8480
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8480
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>         Attachments: HADOOP-8480.001.patch, HADOOP-8480.002.patch
>
>
> Currently, the native build does not honor -DskipTests.  The native unit 
> tests will be run even when you specify:
> {code}
> mvn compile -Pnative -DskipTests -X -e
> {code}
> This seems inconsistent; shouldn't we fix this to work like the other tests 
> do?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to