[ https://issues.apache.org/jira/browse/HADOOP-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433541#comment-13433541 ]
Karthik Kambatla commented on HADOOP-8649: ------------------------------------------ Thanks for the review, Daryn. - I don't think it is incompatible with ChRootedFileSystem as it does not filter out any files. - +1 on generalizing and pushing the change down to FileSystem itself. -- We can add {{protected/public FileSystem#listStatus(Path f, List<PathFilter> filters)}} and use {{MultiPathFilter}} as in {{o.a.h.m.FileInputFormat}} -- All FileSystems can use this to build a list of {{PathFilter}}s to be evaluated. -- {{o.a.h.m.FileInputFormat}} can use the common version of {{MultiPathFilter}} If we decide on this, I can go ahead and make the required changes. > ChecksumFileSystem should have an overriding implementation of > listStatus(Path, PathFilter) for improved performance > -------------------------------------------------------------------------------------------------------------------- > > Key: HADOOP-8649 > URL: https://issues.apache.org/jira/browse/HADOOP-8649 > Project: Hadoop Common > Issue Type: Improvement > Affects Versions: 1.0.3, 2.0.0-alpha > Reporter: Karthik Kambatla > Assignee: Karthik Kambatla > Attachments: branch1-HADOOP-8649.patch, branch1-HADOOP-8649.patch, > HADOOP-8649_branch1.patch, HADOOP-8649_branch1.patch, > HADOOP-8649_branch1.patch_v2, HADOOP-8649_branch1.patch_v3, > TestChecksumFileSystemOnDFS.java, trunk-HADOOP-8649.patch, > trunk-HADOOP-8649.patch > > > Currently, ChecksumFileSystem implements only listStatus(Path). > The other form of listStatus(Path, customFilter) results in parsing the list > twice to apply each of the filters - custom and checksum filter. > By using a composite filter instead, we limit the parsing to once. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira