[ https://issues.apache.org/jira/browse/HADOOP-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436524#comment-13436524 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-8240: ------------------------------------------------ Thanks for the update. Some comments: - We cannot remove ChecksumProto.ChecksumType. Otherwise, it breaks compatibility. - Rename LocalConfigKeys.DEFAULT_CHECKSUM_TYPE to CHECKSUM_TYPE_DEFAULT to that it will be consistent with other field names. - In ChecksumOpt, change crcBlockSize and crcType to final. - Remove CHECKSUM_UNINIT and Type.UNINIT in DataChecksum. Use "null" to represent uninitialized value in ChecksumOpt. > Allow users to specify a checksum type on create() > -------------------------------------------------- > > Key: HADOOP-8240 > URL: https://issues.apache.org/jira/browse/HADOOP-8240 > Project: Hadoop Common > Issue Type: Improvement > Components: fs > Affects Versions: 0.23.0 > Reporter: Kihwal Lee > Assignee: Kihwal Lee > Fix For: 2.1.0-alpha > > Attachments: hadoop-8240.patch, > hadoop-8240-post-hadoop-8700-br2-trunk.patch.txt, > hadoop-8240-post-hadoop-8700-br2-trunk.patch.txt, > hadoop-8240-trunk-branch2.patch.txt, hadoop-8240-trunk-branch2.patch.txt > > > Per discussion in HADOOP-8060, a way for users to specify a checksum type on > create() is needed. The way FileSystem cache works makes it impossible to use > dfs.checksum.type to achieve this. Also checksum-related API is at > Filesystem-level, so we prefer something at that level, not hdfs-specific > one. Current proposal is to use CreatFlag. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira