[ https://issues.apache.org/jira/browse/HADOOP-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448523#comment-13448523 ]
Hadoop QA commented on HADOOP-8749: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12543777/HADOOP-8749_rev2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ha.TestZKFailoverController org.apache.hadoop.conf.TestConfiguration +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1400//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1400//console This message is automatically generated. > HADOOP-8031 changed the way in which relative xincludes are handled in > Configuration. > ------------------------------------------------------------------------------------- > > Key: HADOOP-8749 > URL: https://issues.apache.org/jira/browse/HADOOP-8749 > Project: Hadoop Common > Issue Type: Bug > Components: conf > Reporter: Ahmed Radwan > Assignee: Ahmed Radwan > Attachments: HADOOP-8749.patch, HADOOP-8749_rev2.patch > > > The patch from HADOOP-8031 changed the xml parsing to use > DocumentBuilder#parse(InputStream uri.openStream()) instead of > DocumentBuilder#parse(String uri.toString()).I looked into the implementation > of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there is > a difference when the DocumentBuilder parse(String) method is used versus > parse(InputStream). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira