[ https://issues.apache.org/jira/browse/HADOOP-8767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448958#comment-13448958 ]
Arpit Gupta commented on HADOOP-8767: ------------------------------------- Patch does not seem to be correctly formatted. For details on take a look at http://wiki.apache.org/hadoop/HowToContribute or if you use git then http://wiki.apache.org/hadoop/GitAndHadoop A few comments on your patch. Rather than assigning HOSTLIST after hadoop-env.sh is sourced we should do the following 1. in hadoop-config.sh source the hadoop-env.sh before additional parameters are processed such as --hosts. This way if you specify the hosts at command line they will get set appropriately. This will help as in start-dfs.sh the secondary namenode is being started as {code} "$bin"/hadoop-daemons.sh --config $HADOOP_CONF_DIR --hosts masters start secondarynamenode {code} 2. in slaves.sh remove the source of hadoop-env.sh as it has already been sourced by hadoop-config.sh. Thus the assignment of HADOOP_SLAVES done by hadoop-config.sh will be available rather than being overwritten by hadoop-env.sh > secondary namenode on slave machines > ------------------------------------ > > Key: HADOOP-8767 > URL: https://issues.apache.org/jira/browse/HADOOP-8767 > Project: Hadoop Common > Issue Type: Bug > Components: bin > Affects Versions: 1.0.3 > Reporter: giovanni delussu > Priority: Minor > Fix For: 1.0.3 > > Attachments: patch_hadoop-config.sh_hadoop-1.0.3_fromtar.patch, > patch_slaves.sh_hadoop-1.0.3_fromtar.patch > > > when the default value for HADOOP_SLAVES is changed in hadoop-env.sh the hdfs > starting (with start-dfs.sh) creates secondary namenodes on all the machines > in the file conf/slaves instead of conf/masters. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira