[ 
https://issues.apache.org/jira/browse/HADOOP-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hemanth Yamijala updated HADOOP-8765:
-------------------------------------

    Attachment: HADOOP-8765-for-1-0-x.patch

Patch for branch 1.x, where the ifExists API is still used by IsolationRunner. 

While writing a test for this, I realized that mostly the usage pattern of 
LocalDirAllocator is going to first do a write / read that will end up 
initializing the localDirsPath variable. Hence, the significance of this patch 
is only to the extent that it got IsolationRunner working for me and no real 
impact anywhere else.
                
> LocalDirAllocator.ifExists API is broken and unused
> ---------------------------------------------------
>
>                 Key: HADOOP-8765
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8765
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>            Reporter: Hemanth Yamijala
>            Assignee: Hemanth Yamijala
>            Priority: Minor
>         Attachments: HADOOP-8765-for-1-0-x.patch, HADOOP-8765.patch
>
>
> LocalDirAllocator.ifExists calls AllocatorPerContext.ifExists, which accesses 
> the localDirsPath variable that is uninitialised. Hence, any code that uses 
> this API is likely to fail with a NullPointerException.
> However, this API is currently not used anywhere else in trunk. The earlier 
> usage was in IsolationRunner, that has since been removed via MAPREDUCE-2606.
> Hence, we could remove this API for trunk, and if required, fix it for the 
> 1.x branch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to