[ https://issues.apache.org/jira/browse/HADOOP-8756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454377#comment-13454377 ]
Hadoop QA commented on HADOOP-8756: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12544869/HADOOP-8756.004.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ha.TestZKFailoverController +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1444//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1444//console This message is automatically generated. > Fix SEGV when libsnappy is in java.library.path but not LD_LIBRARY_PATH > ----------------------------------------------------------------------- > > Key: HADOOP-8756 > URL: https://issues.apache.org/jira/browse/HADOOP-8756 > Project: Hadoop Common > Issue Type: Bug > Components: native > Affects Versions: 2.0.2-alpha > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Priority: Minor > Attachments: HADOOP-8756.002.patch, HADOOP-8756.003.patch, > HADOOP-8756.004.patch > > > We use {{System.loadLibrary("snappy")}} from the Java side. However in > libhadoop, we use {{dlopen}} to open libsnappy.so dynamically. > System.loadLibrary uses {{java.library.path}} to resolve libraries, and > {{dlopen}} uses {{LD_LIBRARY_PATH}} and the system paths to resolve > libraries. Because of this, the two library loading functions can be at odds. > We should fix this so we only load the library once, preferably using the > standard Java {{java.library.path}}. > We should also log the search path(s) we use for {{libsnappy.so}} when > loading fails, so that it's easier to diagnose configuration issues. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira