[ https://issues.apache.org/jira/browse/HADOOP-8795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454542#comment-13454542 ]
Hadoop QA commented on HADOOP-8795: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12544913/HADOOP-8795.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1449//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1449//console This message is automatically generated. > BASH tab completion doesn't look in PATH, assumes path to executable is > specified > --------------------------------------------------------------------------------- > > Key: HADOOP-8795 > URL: https://issues.apache.org/jira/browse/HADOOP-8795 > Project: Hadoop Common > Issue Type: Bug > Reporter: Sean Mackrory > Attachments: HADOOP-8795.patch > > > bash-tab-completion/hadoop.sh checks that the first token in the command is > an existing, executable file - which assumes that the path to the hadoop > executable is specified (or that it's in the working directory). If the > executable is somewhere else in PATH, tab completion will not work. > I propose that the first token be passed through 'which' so that any > executables in the path also get detected. I've tested that this technique > will work in the event that relative and absolute paths are used as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira