[ https://issues.apache.org/jira/browse/HADOOP-8815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456600#comment-13456600 ]
Hadoop QA commented on HADOOP-8815: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12545299/HADOOP-8815.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ha.TestZKFailoverController +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1473//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/1473//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1473//console This message is automatically generated. > RandomDatum overrides equals(Object) but no hashCode() > ------------------------------------------------------ > > Key: HADOOP-8815 > URL: https://issues.apache.org/jira/browse/HADOOP-8815 > Project: Hadoop Common > Issue Type: Improvement > Components: test > Affects Versions: 3.0.0 > Reporter: Brandon Li > Assignee: Brandon Li > Priority: Minor > Attachments: HADOOP-8815.patch > > > Override equal() but not hashCode() is a violation of the general contract > for Object.hashCode will occur, which can have unexpected repercussions when > this class is in conjunction with all hash-based collections. > This test class is used in multiple places, so it may be worth fixing. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira