[ 
https://issues.apache.org/jira/browse/HADOOP-7930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461267#comment-13461267
 ] 

Harsh J commented on HADOOP-7930:
---------------------------------

Some comments:

- Use the CommonConfigurationKeysPublic class to constant-ize the config 
strings and its defaults. See the file to get an example. Use these constants 
in the code - instead of hardcoding the config string and the default this way:

{code}
+    try {
+        kerberosMinTimeBeforeRelogin = 1000L * conf.getLong(
+                "hadoop.kerberos.min.time.before.relogin", 60);
{code}
                
> Kerberos relogin interval in UserGroupInformation should be configurable
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-7930
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7930
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.23.1
>            Reporter: Alejandro Abdelnur
>            Assignee: Robert Kanter
>         Attachments: HADOOP-7930.patch
>
>
> Currently the check done in the *hasSufficientTimeElapsed()* method is 
> hardcoded to 10 mins wait.
> The wait time should be driven by configuration and its default value, for 
> clients should be 1 min. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to