[ 
https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463638#comment-13463638
 ] 

Steve Loughran commented on HADOOP-8847:
----------------------------------------

Bikas, you know that the java untar doesn't set FS permissions? Even if that's 
considered unimportant, the big worry I have is over long filenames.

The Ant tar/untar logic doesn't do perms either, but does handle gnu & posix 
extensions:
[ http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/tar/ ]
you can pick this up via Apache Compress: [ http://commons.apache.org/compress/ 
] -I'm not sure that version is up to date w/ Posix patches.

You need tests to verify that 
# filenames > 140 chars can be untarred (tar --format=gnu )
# LFNs in old gnu format are handled (tar --format=oldgnu)
# long filenames in a tar created w/ posix (tar --format=posix)

These files could all be created on a Linux box and added to svn, so that the 
tests on windows will be consistent.

Without tests showing that long filenames are handled, switching to a pure Java 
API will not be backwards compatible and runs a risk of things breaking. Sun's 
implementation cannot handle such files.

                
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
>                 Key: HADOOP-8847
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8847
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>         Attachments: HADOOP-8847.branch-1-win.1.patch, test-untar.tar, 
> test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be 
> present on all platforms by default eg. Windows. So changing this to use JAVA 
> API's would help make it more cross-platform. FileUtil.unZip() uses the same 
> approach.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to