[ https://issues.apache.org/jira/browse/HADOOP-8852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464652#comment-13464652 ]
Tom White commented on HADOOP-8852: ----------------------------------- Generally looks good. * Rather than always starting a DelegationTokenRenewer thread in the HftpFileSystem/WebHdfsFileSystem constructor (which is a bad practice, and is why findbugs is complaining), you could do what WebHdfsFileSystem does already and only start the thread if security is enabled. See the addRenewAction() method on WebHdfsFileSystem. * The 3000ms join timeout could be made into a constant. Perhaps you could add a shutdown method to DelegationTokenRenewer which encapsulates the interrupt and join. > DelegationTokenRenewer thread is not stopped when its filesystem is closed > -------------------------------------------------------------------------- > > Key: HADOOP-8852 > URL: https://issues.apache.org/jira/browse/HADOOP-8852 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 2.0.0-alpha > Reporter: Tom White > Assignee: Karthik Kambatla > Attachments: hadoop-8852.patch, hadoop-8852.patch > > > HftpFileSystem and WebHdfsFileSystem should stop the DelegationTokenRenewer > thread when they are closed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira