[ https://issues.apache.org/jira/browse/HADOOP-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474251#comment-13474251 ]
Jason Lowe commented on HADOOP-8906: ------------------------------------ The corner case is now handled, but the new tests added don't test for it. There should be a test for a non-globbed path for an existing file with the false filter, and all the false filter tests check for either a globbed path or non-existent files. I tried adding a test locally with the false filter for "/" and noticed that it didn't return null. Instead it returned "/" because the filter isn't applied in the special cases of "/" and "", which seems wrong. It turns out that the existing code also had this bug, so I suppose it's at least consistent with the previous version's behavior. > paths with multiple globs are unreliable > ---------------------------------------- > > Key: HADOOP-8906 > URL: https://issues.apache.org/jira/browse/HADOOP-8906 > Project: Hadoop Common > Issue Type: Bug > Components: fs > Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0 > Reporter: Daryn Sharp > Assignee: Daryn Sharp > Priority: Critical > Attachments: HADOOP-8906-branch_0.23.patch, HADOOP-8906.patch, > HADOOP-8906.patch, HADOOP-8906.patch, HADOOP-8906.patch, HADOOP-8906.patch > > > Let's say we have have a structure of "$date/$user/stuff/file". Multiple > globs are unreliable unless every directory in the structure exists. > These work: > date*/user > date*/user/stuff > date*/user/stuff/file > These fail: > date*/user/* > date*/user/*/* > date*/user/stu* > date*/user/stu*/* > date*/user/stu*/file > date*/user/stuff/* > date*/user/stuff/f* -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira