[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475389#comment-13475389 ]
Steve Loughran commented on HADOOP-8847: ---------------------------------------- Bikas -is there any reason to not make the {{close()}} operation in {{unpackEntries()}} part of the try/finally logic? Other than that it looks good to be -the {{Shell.WINDOWS}} checks ensure that the Unix untars will be the existing shell commands and not break anything > Change untar to use Java API instead of spawning tar process > ------------------------------------------------------------ > > Key: HADOOP-8847 > URL: https://issues.apache.org/jira/browse/HADOOP-8847 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Bikas Saha > Assignee: Bikas Saha > Attachments: HADOOP-8847.branch-1-win.1.patch, > HADOOP-8847.branch-1-win.2.patch, test-untar.tar, test-untar.tgz > > > Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be > present on all platforms by default eg. Windows. So changing this to use JAVA > API's would help make it more cross-platform. FileUtil.unZip() uses the same > approach. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira