[ 
https://issues.apache.org/jira/browse/HADOOP-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478338#comment-13478338
 ] 

Robert Joseph Evans commented on HADOOP-8930:
---------------------------------------------

The change looks fine to me, Clover seems to build and run at least as well as 
it did before.  I am +1 for the change.
                
> Cumulative code coverage calculation
> ------------------------------------
>
>                 Key: HADOOP-8930
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8930
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.3, 2.0.2-alpha
>            Reporter: Andrey Klochkov
>            Assignee: Andrey Klochkov
>         Attachments: HADOOP-8930-branch-0.23.patch, HADOOP-8930.patch
>
>
> When analyzing code coverage in Hadoop Core, we noticed that some coverage 
> gaps are caused by the way the coverage calculation is done currently. More 
> specifically, right now coverage can not be calculated for the whole Core at 
> once, but can only be calculated separately for top level modules like 
> common-project, hadoop-hdfs-project etc. 
> At the same time, some code in particular modules is tested by tests in other 
> modules of Core. For example, "org.apache.hadoop.fs" from 
> hadoop-common-project/hadoop-common is not covered there but it's covered by 
> tests under hadoop-hdfs-project.
> To enable calculation of "cumulative" code coverage it's needed to move 
> Clover profile definition up one level, from hadoop-project/pom.xml to the 
> top level pom.xml (hadoop-main).
> Patch both for 0.23 and 2.x will be attached shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to