[ https://issues.apache.org/jira/browse/HADOOP-8874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478795#comment-13478795 ]
Hadoop QA commented on HADOOP-8874: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12549656/fix_home_np.patch against trunk revision . {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1645//console This message is automatically generated. > HADOOP_HOME and -Dhadoop.home (from hadoop wrapper script) are not uniformly > handled > ------------------------------------------------------------------------------------ > > Key: HADOOP-8874 > URL: https://issues.apache.org/jira/browse/HADOOP-8874 > Project: Hadoop Common > Issue Type: Sub-task > Components: scripts, security > Affects Versions: 1-win > Environment: Called from external process with -D flag vs HADOOP_HOME > set. > Reporter: John Gordon > Labels: security > Fix For: 1-win > > Attachments: fix_home_np.patch > > > There is a -D flag to set hadoop.home, which is specified in the hadoop > wrapper scripts. This is particularly useful if you want SxS execution of > two or more versions of hadoop (e.g. rolling upgrade). However, it isn't > honored at all. HADOOP_HOME is used in 3-4 places to find non-java hadoop > components such as schedulers, scripts, shared libraries, or with the Windows > changes -- binaries. > Ideally, these should all resolve the path in a consistent manner, and > callers shuold have a similar onus applied when trying to resolve an invalid > path to their components. This is particularly relevant to scripts or > binaries that may have security impact, as absolute path resolution is > generally safer and more stable than relative path resolution. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira