[ https://issues.apache.org/jira/browse/HADOOP-9005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489685#comment-13489685 ]
Chris Nauroth commented on HADOOP-9005: --------------------------------------- Hello, Ivan. A few comments: # hadoop-config.cmd line 156: This might be easier with an else clause instead of checking defined HADOOP_USER_CLASSPATH_FIRST a second time. # hadoop.cmd line 138: Why is it important to disable HADOOP_SECURITY_LOGGER? # hadoop-env.cmd line 25: Should we add a commented out set JAVA_HOME line here? > Merge hadoop cmd line scripts from branch-1-win > ----------------------------------------------- > > Key: HADOOP-9005 > URL: https://issues.apache.org/jira/browse/HADOOP-9005 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: trunk-win > Reporter: Ivan Mitic > Assignee: Ivan Mitic > Attachments: HADOOP-9005.branch-trunk-win.scripts.2.patch, > HADOOP-9005.branch-trunk-win.scripts.3.patch, > HADOOP-9005.branch-trunk-win.scripts.4.patch, > HADOOP-9005.branch-trunk-win.scripts.patch > > > Tracking Jira for merging hadoop cmd line scripts from branch-1-win to trunk. > Scripts also have to be updated to reflect their unix equivalents. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira