[ https://issues.apache.org/jira/browse/HADOOP-8615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490842#comment-13490842 ]
Andy Isaacson commented on HADOOP-8615: --------------------------------------- bq. Please let me know for any feedback. Sorry for the delay! A few more whitespace fixups: - make sure {{) throws}} has a space between the ) and "throws". (2 examples in this patch) - still a few argument lists missing a space after "," for example {{return createInputStream(in, null,fileName);}}. - also a few argument lists with extra spaces before "," for example {{Decompressor decompressor , String fileName}} - extra space in {{protected String fileName}} - extra space in {{this.fileName = fileName}} - missing spaces in {{\+"file = "\+this.fileName}}, always put spaces on both sides of "\+" and other operators. also we generally put the "+" on the previous line for a string continuation like this one. - missing space in {{if ((b1 | b2 | b3 | b4) < 0\)\{}} before "{" - missing space in {{String fileName ="fileName";}} after "=" Thanks again for working on this enhancement! > EOFException in DecompressorStream.java needs to be more verbose > ---------------------------------------------------------------- > > Key: HADOOP-8615 > URL: https://issues.apache.org/jira/browse/HADOOP-8615 > Project: Hadoop Common > Issue Type: Bug > Components: io > Affects Versions: 0.20.2 > Reporter: Jeff Lord > Labels: patch > Attachments: HADOOP-8615.patch, HADOOP-8615-release-0.20.2.patch, > HADOOP-8615-ver2.patch > > > In ./src/core/org/apache/hadoop/io/compress/DecompressorStream.java > The following exception should at least pass back the file that it encounters > this error in relation to: > protected void getCompressedData() throws IOException { > checkStream(); > int n = in.read(buffer, 0, buffer.length); > if (n == -1) { > throw new EOFException("Unexpected end of input stream"); > } > This would help greatly to debug bad/corrupt files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira