[ 
https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509442#comment-13509442
 ] 

Todd Lipcon commented on HADOOP-9112:
-------------------------------------

Another option might be to require that all classes containing test methods be 
annotated with a JUnit rule which enforces default timeouts. I'm not enough of 
a JUnit expert to know the best way. Any ideas from folks more versed in Rules, 
etc?
                
> test-patch should -1 for @Tests without a timeout
> -------------------------------------------------
>
>                 Key: HADOOP-9112
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9112
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Todd Lipcon
>
> With our current test running infrastructure, if a test with no timeout set 
> runs too long, it triggers a surefire-wide timeout, which for some reason 
> doesn't show up as a failed test in the test-patch output. Given that, we 
> should require that all tests have a timeout set, and have test-patch enforce 
> this with a simple check

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to