[ 
https://issues.apache.org/jira/browse/HADOOP-9119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531649#comment-13531649
 ] 

Eli Collins commented on HADOOP-9119:
-------------------------------------

Don't think the char to String conversion method is necessary, String#format 
handles bytes right? Otherwise looks good.
                
> Add test to FileSystemContractBaseTest to verify integrity of overwritten 
> files
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-9119
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9119
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: HADOOP-9119.patch
>
>
> The test {{FileSystemContractBaseTest.testOverwrite()}} is meant to verify 
> that overwrites work -but it only overwrites a zero byte file with some data 
> and only checks for length. This can hide problems where there overwrite was 
> somehow corrupted.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to